Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CRUD Suite] Delete extra subnet before deleting cluster #7248

Merged
merged 13 commits into from
Nov 3, 2023
Merged

[CRUD Suite] Delete extra subnet before deleting cluster #7248

merged 13 commits into from
Nov 3, 2023

Conversation

TiberiuGC
Copy link
Collaborator

Description

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@TiberiuGC TiberiuGC added the skip-release-notes Causes PR not to show in release notes label Nov 3, 2023
@cPu1
Copy link
Collaborator

cPu1 commented Nov 3, 2023

There are some additional commits in this PR, you'll have to rebase with main.

@TiberiuGC
Copy link
Collaborator Author

TiberiuGC commented Nov 3, 2023 •
edited
Loading

There are some additional commits in this PR, you'll have to rebase with main.

I think it's showing the full commit history since I'm using the same branch I've used for the improvement PR itself. 😕

eksctl % git fetch upstream 
eksctl % git merge upstream/main
Already up to date.

@TiberiuGC @cPu1
fix typo
6da4bae 
Co-authored-by: Chetan Patwal <cPu1@users.noreply.github.com>
@TiberiuGC TiberiuGC added skip-release-notes Causes PR not to show in release notes and removed skip-release-notes Causes PR not to show in release notes labels Nov 3, 2023
@TiberiuGC
Copy link
Collaborator Author

Just an extra note that we'd probably want to remove the --wait flag from cluster deletion after confirming it's not failing anymore. Otherwise it mitigates most of the runtime improvement.

@TiberiuGC TiberiuGC merged commit c402580 into main Nov 3, 2023
9 checks passed
@TiberiuGC TiberiuGC deleted the maintenance/improve-crud-suite-runtime branch November 3, 2023 13:15
IdanShohamNetApp pushed a commit to spotinst/weaveworks-eksctl that referenced this pull request Jun 2, 2024
@TiberiuGC @cPu1 @IdanShohamNetApp
[CRUD Suite] Delete extra subnet before deleting cluster (eksctl-io#7248
72b918c 
)

* Improve CRUD suite runtime~

* refactor to use ginkgo decorators

* fix IAM service account

* change cluster name

* remove duplicate cluster workloads test

* refactor describe stacks test

* [CRUD integration] Add wait flag to delete cluster command

* delete additional subnet

* fix typo

Co-authored-by: Chetan Patwal <cPu1@users.noreply.github.com>

* small refactor to trigger workflows

---------

Co-authored-by: Chetan Patwal <cPu1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cPu1 cPu1 cPu1 approved these changes

Assignees
No one assigned
Labels
skip-release-notes Causes PR not to show in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TiberiuGC @cPu1